Skip to content

ci(vrt): install vr-app as part of standard yarn install and remedy necessary duplication #32048

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
Hotell merged 8 commits into from
Jul 22, 2024
Merged

ci(vrt): install vr-app as part of standard yarn install and remedy necessary duplication #32048

Hotell merged 8 commits into from
Jul 22, 2024

Conversation

@Hotell
Copy link
Contributor

@Hotell Hotell commented Jul 18, 2024 •
edited
Loading

Previous Behavior

New Behavior

  • removes dupes in vrt pipelines + mitigates global vr-approval-cli install on ci
  • explicitly installs latest minor version (in order to support managed identity ci(vrt): upgrade VR tool to be security compliant #31997) of vr-approval-cli, which doesn't ship its binary via windows CLRF endings (issue with 0.0.168 that was used on CI), thus we can run it via local binary cmd -> yarn vr-app --help works !
  • removes vrscreenshotdiff which is depreacated/unmaintained/not-needed

Side effects:

  • cleanup exposed ghost(transitive) dependency used within v0 gulp logic - in order to make things work request is now explicit devDependency within monorepo
  • cleanup also set tslib to resolve to latest 2.6. so in order to avoid dupes we bump the monorepo version to latest -> which has minor negative effect on v8 bundle size ( but users depending on tslib 2.6 have those bundle increases already part of their bundles, so this is not a issue on our side - we specify tslib ^2.1 )

🕵️‍♂️ bundle-size diff:

seems not related to tslib bump at all

Button (same for Comobox and others ):

image

Related Issue(s)

@github-actions github-actions bot added this to the July Project Cycle Q3 2024 milestone Jul 18, 2024
@Hotell Hotell changed the title Ci/vrt/cleanup cli downloads ci(vrt): install vr-app as part of standard yarn install and remedy necessary duplication Jul 18, 2024
@fabricteam
Copy link
Collaborator

fabricteam commented Jul 18, 2024 •
edited
Loading

Perf Analysis (@fluentui/react-components)

No significant results to display.

All results

Scenario Render type Master Ticks PR Ticks Iterations Status
Avatar mount 656 620 5000
Button mount 310 312 5000
Field mount 1141 1147 5000
FluentProvider mount 770 703 5000
FluentProviderWithTheme mount 100 95 10
FluentProviderWithTheme virtual-rerender 42 43 10
FluentProviderWithTheme virtual-rerender-with-unmount 94 92 10
MakeStyles mount 874 857 50000
Persona mount 1877 1706 5000
SpinButton mount 1406 1385 5000
SwatchPicker mount 1688 1689 5000

@fabricteam
Copy link
Collaborator

fabricteam commented Jul 18, 2024 •
edited
Loading

📊 Bundle size report

Package & Exports Baseline (minified/GZIP) PR Change
react
ActivityItem		 71.147 kB
23.33 kB		 71.199 kB
23.342 kB		 52 B
12 B
react
Announced		 38.423 kB
13.289 kB		 38.48 kB
13.282 kB		 57 B
-7 B
react
Autofill		 15.373 kB
4.746 kB		 15.428 kB
4.768 kB		 55 B
22 B
react
Breadcrumb		 202.103 kB
60.438 kB		 202.16 kB
60.414 kB		 57 B
-24 B
react
Button		 195.56 kB
56.621 kB		 195.612 kB
56.635 kB		 52 B
14 B
react
ButtonGrid		 180.489 kB
54.65 kB		 180.546 kB
54.615 kB		 57 B
-35 B
react
Calendar		 121.686 kB
36.985 kB		 121.738 kB
36.999 kB		 52 B
14 B
react
Callout		 84.235 kB
27.603 kB		 84.292 kB
27.63 kB		 57 B
27 B
react
Check		 53.091 kB
17.837 kB		 53.16 kB
17.832 kB		 69 B
-5 B
react
Checkbox		 59.879 kB
19.865 kB		 59.946 kB
19.879 kB		 67 B
14 B
react
ChoiceGroup		 65.403 kB
21.465 kB		 65.455 kB
21.478 kB		 52 B
13 B
react
ChoiceGroupOption		 58.659 kB
19.356 kB		 58.723 kB
19.355 kB		 64 B
-1 B
react
Coachmark		 93.063 kB
29.408 kB		 93.132 kB
29.416 kB		 69 B
8 B
react
Color		 7.737 kB
3.106 kB		 7.789 kB
3.127 kB		 52 B
21 B
react
ColorPicker		 133.168 kB
41.574 kB		 133.22 kB
41.588 kB		 52 B
14 B
react
ComboBox		 252 kB
72.314 kB		 252.052 kB
72.328 kB		 52 B
14 B
react
CommandBar		 203.139 kB
60.138 kB		 203.201 kB
60.138 kB		 62 B
react
ContextualMenu		 155.031 kB
48.167 kB		 155.083 kB
48.18 kB		 52 B
13 B
react
DatePicker		 184.108 kB
56.151 kB		 184.16 kB
56.164 kB		 52 B
13 B
react
DetailsList		 229.725 kB
65.872 kB		 229.78 kB
65.894 kB		 55 B
22 B
react
Dialog		 211.415 kB
63.144 kB		 211.467 kB
63.157 kB		 52 B
13 B
react
Divider		 19.531 kB
6.862 kB		 19.591 kB
6.841 kB		 60 B
-21 B
react
DocumentCard		 217.096 kB
64.44 kB		 217.153 kB
64.431 kB		 57 B
-9 B
react
DraggableZone		 34.242 kB
11.488 kB		 34.305 kB
11.509 kB		 63 B
21 B
react
Dropdown		 234.047 kB
68.658 kB		 234.099 kB
68.671 kB		 52 B
13 B
react
ExtendedPicker		 96.737 kB
27.87 kB		 96.795 kB
27.893 kB		 58 B
23 B
react
Fabric		 41.665 kB
14.358 kB		 41.732 kB
14.349 kB		 67 B
-9 B
react
Facepile		 210.688 kB
63.203 kB		 210.755 kB
63.183 kB		 67 B
-20 B
react
FloatingPicker		 242.144 kB
69.006 kB		 242.196 kB
69.02 kB		 52 B
14 B
react
FocusTrapZone		 16.978 kB
5.916 kB		 17.03 kB
5.924 kB		 52 B
8 B
react
FocusZone		 54.988 kB
17.451 kB		 55.053 kB
17.47 kB		 65 B
19 B
react
Grid		 180.489 kB
54.65 kB		 180.546 kB
54.615 kB		 57 B
-35 B
react
GroupedList		 134.953 kB
40.737 kB		 135.005 kB
40.75 kB		 52 B
13 B
react
GroupedListV2		 122.542 kB
37.835 kB		 122.594 kB
37.849 kB		 52 B
14 B
react
HoverCard		 97.108 kB
30.803 kB		 97.16 kB
30.816 kB		 52 B
13 B
react
Icon		 51.772 kB
17.252 kB		 51.848 kB
17.254 kB		 76 B
2 B
react
Icons		 66.309 kB
24.381 kB		 66.361 kB
24.397 kB		 52 B
16 B
react
Image		 46.829 kB
15.701 kB		 46.887 kB
15.703 kB		 58 B
2 B
react
Keytip		 81.609 kB
26.745 kB		 81.661 kB
26.758 kB		 52 B
13 B
react
KeytipData		 13.973 kB
4.573 kB		 14.028 kB
4.587 kB		 55 B
14 B
react
KeytipLayer		 103.407 kB
32.001 kB		 103.459 kB
32.014 kB		 52 B
13 B
react
Keytips		 106.175 kB
33.001 kB		 106.227 kB
33.014 kB		 52 B
13 B
react
Label		 38.266 kB
13.244 kB		 38.335 kB
13.251 kB		 69 B
7 B
react
Layer		 48.015 kB
16.337 kB		 48.084 kB
16.358 kB		 69 B
21 B
react
Link		 39.616 kB
13.649 kB		 39.668 kB
13.662 kB		 52 B
13 B
react
List		 39.332 kB
12.454 kB		 39.4 kB
12.481 kB		 68 B
27 B
react
MarqueeSelection		 74.471 kB
22.439 kB		 74.528 kB
22.424 kB		 57 B
-15 B
react
MessageBar		 190.593 kB
57.089 kB		 190.65 kB
57.064 kB		 57 B
-25 B
react
Modal		 93.568 kB
30.226 kB		 93.632 kB
30.242 kB		 64 B
16 B
react
Nav		 188.092 kB
56.536 kB		 188.15 kB
56.514 kB		 58 B
-22 B
react
OverflowSet		 33.318 kB
11.313 kB		 33.376 kB
11.317 kB		 58 B
4 B
react
Overlay		 40.822 kB
14.083 kB		 40.889 kB
14.084 kB		 67 B
1 B
react
Panel		 201.15 kB
60.044 kB		 201.208 kB
60.025 kB		 58 B
-19 B
react
Persona		 114.753 kB
36.48 kB		 114.805 kB
36.493 kB		 52 B
13 B
react
PersonaCoin		 114.753 kB
36.48 kB		 114.805 kB
36.493 kB		 52 B
13 B
react
PersonaPresence		 57.961 kB
19.359 kB		 58.03 kB
19.368 kB		 69 B
9 B
react
Pickers		 293.979 kB
82.41 kB		 294.031 kB
82.422 kB		 52 B
12 B
react
Pivot		 188.985 kB
57.253 kB		 189.043 kB
57.242 kB		 58 B
-11 B
react
Popup		 12.242 kB
4.181 kB		 12.294 kB
4.195 kB		 52 B
14 B
react
Positioning		 22.736 kB
7.685 kB		 22.807 kB
7.701 kB		 71 B
16 B
react
PositioningContainer		 73.773 kB
23.756 kB		 73.838 kB
23.759 kB		 65 B
3 B
react
ProgressIndicator		 39.424 kB
13.548 kB		 39.491 kB
13.54 kB		 67 B
-8 B
react
Rating		 81.906 kB
26.107 kB		 81.97 kB
26.1 kB		 64 B
-7 B
react
Fluent UI React (entire library)		 1.014 MB
281.89 kB		 1.014 MB
281.903 kB		 52 B
13 B
react
ResizeGroup		 13.286 kB
4.365 kB		 13.338 kB
4.377 kB		 52 B
12 B
react
ResponsiveMode		 8.078 kB
2.95 kB		 8.13 kB
2.966 kB		 52 B
16 B
react
ScrollablePane		 55.462 kB
17.736 kB		 55.53 kB
17.73 kB		 68 B
-6 B
react
SearchBox		 188.868 kB
56.696 kB		 188.925 kB
56.674 kB		 57 B
-22 B
react
SelectedItemsList		 232.641 kB
67.937 kB		 232.707 kB
67.921 kB		 66 B
-16 B
react
Selection		 42.4 kB
12.278 kB		 42.464 kB
12.301 kB		 64 B
23 B
react
Separator		 35.315 kB
12.157 kB		 35.372 kB
12.142 kB		 57 B
-15 B
react
Shimmer		 49.177 kB
16.256 kB		 49.238 kB
16.264 kB		 61 B
8 B
react
ShimmeredDetailsList		 240.5 kB
68.626 kB		 240.562 kB
68.628 kB		 62 B
2 B
react
Slider		 57.576 kB
19.191 kB		 57.639 kB
19.206 kB		 63 B
15 B
react
SpinButton		 192.596 kB
57.8 kB		 192.654 kB
57.781 kB		 58 B
-19 B
react
Spinner		 41.706 kB
14.477 kB		 41.764 kB
14.469 kB		 58 B
-8 B
react
Stack		 41.675 kB
14.283 kB		 41.734 kB
14.268 kB		 59 B
-15 B
react
Sticky		 32.555 kB
10.494 kB		 32.613 kB
10.509 kB		 58 B
15 B
react
Styling		 45.981 kB
15.121 kB		 46.033 kB
15.135 kB		 52 B
14 B
react
SwatchColorPicker		 190.814 kB
58.139 kB		 190.871 kB
58.117 kB		 57 B
-22 B
react
TeachingBubble		 205.872 kB
61.029 kB		 205.924 kB
61.042 kB		 52 B
13 B
react
Text		 36.851 kB
12.828 kB		 36.908 kB
12.822 kB		 57 B
-6 B
react
TextField		 80.709 kB
25.324 kB		 80.767 kB
25.323 kB		 58 B
-1 B
react
Theme		 43.449 kB
14.169 kB		 43.501 kB
14.183 kB		 52 B
14 B
react
ThemeGenerator		 12.34 kB
4.106 kB		 12.392 kB
4.126 kB		 52 B
20 B
react
TimePicker		 241.776 kB
70.065 kB		 241.828 kB
70.079 kB		 52 B
14 B
react
Toggle		 46.148 kB
15.96 kB		 46.21 kB
15.966 kB		 62 B
6 B
react
Tooltip		 87.272 kB
28.203 kB		 87.324 kB
28.217 kB		 52 B
14 B
react
Utilities		 82.623 kB
25.106 kB		 82.675 kB
25.119 kB		 52 B
13 B
react
Viewport		 23.831 kB
7.638 kB		 23.888 kB
7.656 kB		 57 B
18 B
react
WeeklyDayPicker		 101.84 kB
31.805 kB		 101.892 kB
31.818 kB		 52 B
13 B
Unchanged fixtures
Package & Exports Size (minified/GZIP)
global-context
createContext		 510 B
328 B
global-context
createContextSelector		 537 B
339 B
keyboard-key
keyboard-key package		 3.746 kB
1.928 kB
priority-overflow
createOverflowManager		 4.457 kB
1.856 kB
react
DateTimeUtilities		 5.244 kB
1.849 kB
react
DragDrop		 8.343 kB
2.724 kB
react
SelectableOption		 724 B
413 B
react
WindowProvider		 1.059 kB
541 B
react-accordion
Accordion (including children components)		 99.137 kB
30.201 kB
react-avatar
Avatar		 49.301 kB
15.838 kB
react-avatar
AvatarGroup		 20.107 kB
7.973 kB
react-avatar
AvatarGroupItem		 63.445 kB
20.061 kB
react-badge
Badge		 25.952 kB
8.614 kB
react-badge
CounterBadge		 26.731 kB
8.887 kB
react-badge
PresenceBadge		 25.719 kB
9.485 kB
react-breadcrumb
@fluentui/react-breadcrumb - package		 113.697 kB
31.537 kB
react-button
Button		 37.105 kB
10.785 kB
react-button
CompoundButton		 43.516 kB
12.076 kB
react-button
MenuButton		 41.912 kB
12.137 kB
react-button
SplitButton		 49.924 kB
13.73 kB
react-button
ToggleButton		 53.035 kB
12.546 kB
react-calendar-compat
Calendar Compat		 149.573 kB
39.871 kB
react-card
Card - All		 100.845 kB
28.873 kB
react-card
Card		 93.629 kB
27.077 kB
react-card
CardFooter		 14.356 kB
5.798 kB
react-card
CardHeader		 16.879 kB
6.664 kB
react-card
CardPreview		 14.42 kB
5.934 kB
react-checkbox
Checkbox		 35.105 kB
12.112 kB
react-combobox
Combobox (including child components)		 103.623 kB
34.007 kB
react-combobox
Dropdown (including child components)		 104.209 kB
33.914 kB
react-components
react-components: Button, FluentProvider & webLightTheme		 69.141 kB
20.157 kB
react-components
react-components: Accordion, Button, FluentProvider, Image, Menu, Popover		 211.781 kB
60.963 kB
react-components
react-components: FluentProvider & webLightTheme		 44.442 kB
14.607 kB
react-components
react-components: entire library		 1.096 MB
271.195 kB
react-datepicker-compat
DatePicker Compat		 223.049 kB
63.147 kB
react-dialog
Dialog (including children components)		 99.491 kB
29.895 kB
react-divider
Divider		 21.328 kB
7.965 kB
react-field
Field		 23.384 kB
8.903 kB
react-image
Image		 15.362 kB
6.248 kB
react-input
Input		 28.015 kB
9.456 kB
react-jsx-runtime
Classic Pragma		 1.057 kB
530 B
react-jsx-runtime
JSX Dev Runtime		 3.781 kB
1.646 kB
react-jsx-runtime
JSX Runtime		 4.377 kB
1.881 kB
react-label
Label		 14.672 kB
6.002 kB
react-link
Link		 17.193 kB
6.993 kB
react-menu
Menu (including children components)		 151.286 kB
45.713 kB
react-menu
Menu (including selectable components)		 153.972 kB
46.205 kB
react-message-bar
MessageBar (all components)		 24.596 kB
9.18 kB
react-motion
@fluentui/react-motion - createMotionComponent()		 4.173 kB
1.847 kB
react-motion
@fluentui/react-motion - createPresenceComponent()		 4.934 kB
2.177 kB
react-motion
@fluentui/react-motion - PresenceGroup		 1.714 kB
819 B
react-northstar
Accordion		 85.392 kB
26.518 kB
react-northstar
Alert		 87.45 kB
26.902 kB
react-northstar
Animation		 55.34 kB
17.829 kB
react-northstar
Attachment		 86.844 kB
26.692 kB
react-northstar
Avatar		 80.279 kB
24.629 kB
react-northstar
Box		 75.248 kB
23.806 kB
react-northstar
Breadcrumb		 79.92 kB
24.709 kB
react-northstar
Button		 83.16 kB
25.947 kB
react-northstar
Card		 82.705 kB
25.023 kB
react-northstar
Carousel		 105.182 kB
31.871 kB
react-northstar
Chat		 154.09 kB
46.847 kB
react-northstar
Checkbox		 79.807 kB
25.078 kB
react-northstar
Datepicker		 186.651 kB
56.973 kB
react-northstar
Debug		 8.801 kB
3.594 kB
react-northstar
Design		 36.589 kB
12.067 kB
react-northstar
Dialog		 112.058 kB
33.615 kB
react-northstar
Divider		 76.619 kB
24.129 kB
react-northstar
Dropdown		 198.211 kB
60.214 kB
react-northstar
Embed		 81.477 kB
25.417 kB
react-northstar
Flex		 47.728 kB
15.438 kB
react-northstar
Form		 92.527 kB
28.879 kB
react-northstar
Grid		 70.584 kB
22.278 kB
react-northstar
Header		 74.756 kB
23.461 kB
react-northstar
Image		 73.591 kB
23.329 kB
react-northstar
Input		 88.346 kB
27.78 kB
react-northstar
ItemLayout		 78.231 kB
24.454 kB
react-northstar
Label		 77.92 kB
24.41 kB
react-northstar
Layout		 75.393 kB
23.798 kB
react-northstar
List		 88.493 kB
27.547 kB
react-northstar
Loader		 78.616 kB
24.729 kB
react-northstar
Menu		 128.602 kB
40.717 kB
react-northstar
MenuButton		 163.008 kB
49.606 kB
react-northstar
Pill		 83.722 kB
26.069 kB
react-northstar
Popup		 135.316 kB
42.242 kB
react-northstar
Portal		 58.338 kB
18.852 kB
react-northstar
Provider		 93.138 kB
29.63 kB
react-northstar
RadioGroup		 83.282 kB
26.053 kB
react-northstar
Reaction		 77.28 kB
24.122 kB
react-northstar
Segment		 76.209 kB
23.892 kB
react-northstar
Skeleton		 77.765 kB
24.2 kB
react-northstar
Slider		 84.27 kB
26.737 kB
react-northstar
SplitButton		 178.246 kB
53.42 kB
react-northstar
Status		 76.272 kB
24.05 kB
react-northstar
SvgIcon		 36.823 kB
11.743 kB
react-northstar
Table		 80.796 kB
25.154 kB
react-northstar
Text		 74.114 kB
23.507 kB
react-northstar
TextArea		 74.248 kB
23.492 kB
react-northstar
Toolbar		 175.057 kB
52.832 kB
react-northstar
Tooltip		 109.973 kB
35.227 kB
react-northstar
Tree		 87.855 kB
27.217 kB
react-northstar
Video		 75.411 kB
23.799 kB
react-overflow
hooks only		 12.821 kB
4.813 kB
react-persona
Persona		 56.192 kB
17.728 kB
react-popover
Popover		 127.198 kB
39.776 kB
react-portal
Portal		 14.563 kB
5.118 kB
react-portal-compat
PortalCompatProvider		 8.39 kB
2.64 kB
react-positioning
usePositioning		 26.489 kB
9.552 kB
react-progress
ProgressBar		 17.086 kB
6.906 kB
react-provider
FluentProvider		 24.618 kB
8.906 kB
react-radio
Radio		 32.673 kB
10.351 kB
react-radio
RadioGroup		 15.76 kB
6.433 kB
react-select
Select		 27.723 kB
10.131 kB
react-slider
Slider		 37.17 kB
12.547 kB
react-spinbutton
SpinButton		 36.102 kB
11.85 kB
react-spinner
Spinner		 25.246 kB
8.554 kB
react-swatch-picker
@fluentui/react-swatch-picker - package		 103.73 kB
30.098 kB
react-switch
Switch		 35.301 kB
11.348 kB
react-table
DataGrid		 160.337 kB
45.661 kB
react-table
Table (Primitives only)		 42.482 kB
13.868 kB
react-table
Table as DataGrid		 131.142 kB
36.351 kB
react-table
Table (Selection only)		 70.336 kB
20.028 kB
react-table
Table (Sort only)		 68.979 kB
19.633 kB
react-tag-picker
@fluentui/react-tag-picker - package		 181.227 kB
54.489 kB
react-tags
InteractionTag		 15.167 kB
6.135 kB
react-tags
Tag		 28.996 kB
9.52 kB
react-tags
TagGroup		 82.124 kB
24.344 kB
react-text
Text - Default		 17.063 kB
6.733 kB
react-text
Text - Wrappers		 20.235 kB
7.064 kB
react-textarea
Textarea		 26.572 kB
9.769 kB
react-theme
Single theme token import		 69 B
89 B
react-theme
Teams: all themes		 35.666 kB
7.453 kB
react-theme
Teams: Light theme		 19.642 kB
5.549 kB
react-timepicker-compat
TimePicker		 106.611 kB
35.546 kB
react-toast
Toast (including Toaster)		 97.701 kB
29.409 kB
react-tooltip
Tooltip		 54.558 kB
19.23 kB
react-utilities
SSRProvider		 180 B
160 B
🤖 This report was generated against ba0b6c57703f35cb703243c77ecdce6cff1c0e51

@fabricteam
Copy link
Collaborator

fabricteam commented Jul 18, 2024 •
edited
Loading

Perf Analysis (@fluentui/react-northstar)

Perf tests with no regressions
Scenario Current PR Ticks Baseline Ticks Ratio
FlexMinimalPerf.default 178 152 1.17:1
ButtonMinimalPerf.default 97 86 1.13:1
TreeWith60ListItems.default 90 81 1.11:1
SliderMinimalPerf.default 814 738 1.1:1
ImageMinimalPerf.default 233 213 1.09:1
GridMinimalPerf.default 200 185 1.08:1
ProviderMinimalPerf.default 210 194 1.08:1
BoxMinimalPerf.default 207 193 1.07:1
RadioGroupMinimalPerf.default 280 261 1.07:1
RefMinimalPerf.default 118 110 1.07:1
DropdownManyItemsPerf.default 400 377 1.06:1
FormMinimalPerf.default 236 223 1.06:1
ItemLayoutMinimalPerf.default 738 693 1.06:1
MenuMinimalPerf.default 522 497 1.05:1
PortalMinimalPerf.default 87 83 1.05:1
TextMinimalPerf.default 209 200 1.05:1
CardMinimalPerf.default 317 305 1.04:1
DialogMinimalPerf.default 460 444 1.04:1
HeaderSlotsPerf.default 470 451 1.04:1
InputMinimalPerf.default 559 539 1.04:1
VideoMinimalPerf.default 462 445 1.04:1
AnimationMinimalPerf.default 299 289 1.03:1
ButtonOverridesMissPerf.default 666 647 1.03:1
LoaderMinimalPerf.default 191 185 1.03:1
RosterPerf.default 1649 1599 1.03:1
TooltipMinimalPerf.default 1320 1280 1.03:1
AlertMinimalPerf.default 156 153 1.02:1
AttachmentMinimalPerf.default 82 80 1.02:1
CarouselMinimalPerf.default 259 255 1.02:1
ChatMinimalPerf.default 441 432 1.02:1
CheckboxMinimalPerf.default 1173 1146 1.02:1
EmbedMinimalPerf.default 1885 1851 1.02:1
LabelMinimalPerf.default 220 215 1.02:1
SegmentMinimalPerf.default 202 198 1.02:1
SplitButtonMinimalPerf.default 2256 2204 1.02:1
StatusMinimalPerf.default 398 392 1.02:1
TableManyItemsPerf.default 1125 1101 1.02:1
CustomToolbarPrototype.default 1494 1459 1.02:1
ChatWithPopoverPerf.default 205 203 1.01:1
DropdownMinimalPerf.default 1426 1418 1.01:1
ListMinimalPerf.default 318 315 1.01:1
ListNestedPerf.default 326 322 1.01:1
ListWith60ListItems.default 379 375 1.01:1
MenuButtonMinimalPerf.default 953 944 1.01:1
SkeletonMinimalPerf.default 208 205 1.01:1
TextAreaMinimalPerf.default 301 297 1.01:1
ToolbarMinimalPerf.default 554 547 1.01:1
TreeMinimalPerf.default 489 485 1.01:1
ChatDuplicateMessagesPerf.default 154 154 1:1
HeaderMinimalPerf.default 212 212 1:1
ListCommonPerf.default 395 396 1:1
PopupMinimalPerf.default 347 346 1:1
TableMinimalPerf.default 234 233 1:1
ButtonSlotsPerf.default 314 318 0.99:1
DatepickerMinimalPerf.default 3677 3714 0.99:1
DividerMinimalPerf.default 199 202 0.99:1
LayoutMinimalPerf.default 195 197 0.99:1
ProviderMergeThemesPerf.default 639 648 0.99:1
ReactionMinimalPerf.default 215 219 0.98:1
AccordionMinimalPerf.default 84 87 0.97:1
AttachmentSlotsPerf.default 630 647 0.97:1
IconMinimalPerf.default 375 396 0.95:1
AvatarMinimalPerf.default 108 115 0.94:1

@fabricteam
Copy link
Collaborator

fabricteam commented Jul 18, 2024 •
edited
Loading

Perf Analysis (@fluentui/react)

No significant results to display.

All results

Scenario Render type Master Ticks PR Ticks Iterations Status
BaseButton mount 633 630 5000
Breadcrumb mount 1699 1697 1000
Checkbox mount 1740 1713 5000
CheckboxBase mount 1519 1493 5000
ChoiceGroup mount 3024 3073 5000
ComboBox mount 680 695 1000
CommandBar mount 6663 6854 1000
ContextualMenu mount 13681 14087 1000
DefaultButton mount 801 778 5000
DetailsRow mount 2205 2310 5000
DetailsRowFast mount 2233 2266 5000
DetailsRowNoStyles mount 2030 2020 5000
Dialog mount 2712 2822 1000
DocumentCardTitle mount 229 236 1000
Dropdown mount 2026 2027 5000
FocusTrapZone mount 1163 1138 5000
FocusZone mount 1093 1128 5000
GroupedList mount 42303 42670 2
GroupedList virtual-rerender 20445 20641 2
GroupedList virtual-rerender-with-unmount 52679 52346 2
GroupedListV2 mount 226 239 2
GroupedListV2 virtual-rerender 214 215 2
GroupedListV2 virtual-rerender-with-unmount 237 241 2
IconButton mount 1153 1135 5000
Label mount 344 354 5000
Layer mount 2740 2746 5000
Link mount 395 392 5000
MenuButton mount 1024 994 5000
MessageBar mount 21361 21306 5000
Nav mount 2079 2125 1000
OverflowSet mount 801 799 5000
Panel mount 1843 1810 1000
Persona mount 730 790 1000
Pivot mount 896 909 1000
PrimaryButton mount 943 911 5000
Rating mount 4727 4725 5000
SearchBox mount 950 927 5000
Shimmer mount 1899 1873 5000
Slider mount 1404 1346 5000
SpinButton mount 2999 2958 5000
Spinner mount 401 393 5000
SplitButton mount 1866 1865 5000
Stack mount 427 436 5000
StackWithIntrinsicChildren mount 883 914 5000
StackWithTextChildren mount 2792 2758 5000
SwatchColorPicker mount 6432 6455 5000
TagPicker mount 1468 1477 5000
Text mount 388 387 5000
TextField mount 956 939 5000
ThemeProvider mount 850 852 5000
ThemeProvider virtual-rerender 580 590 5000
ThemeProvider virtual-rerender-with-unmount 1297 1277 5000
Toggle mount 636 609 5000
buttonNative mount 192 188 5000

@fabricteam
Copy link
Collaborator

fabricteam commented Jul 18, 2024 •
edited
Loading

🕵 fluentui-web-components-v3 No visual regressions between this PR and main

@fabricteam
Copy link
Collaborator

fabricteam commented Jul 18, 2024 •
edited
Loading

🕵 fluentuiv8 No visual regressions between this PR and main

@fabricteam
Copy link
Collaborator

fabricteam commented Jul 18, 2024 •
edited
Loading

🕵 FluentUIV0 No visual regressions between this PR and main

fabricteam
fabricteam reviewed Jul 18, 2024
View reviewed changes
@Hotell Hotell marked this pull request as ready for review July 18, 2024 17:14
@Hotell Hotell requested a review from a team as a code owner July 18, 2024 17:14
@Hotell Hotell requested a review from TristanWatanabe July 18, 2024 17:14
@Hotell Hotell mentioned this pull request Jul 18, 2024
Closed
@Hotell Hotell force-pushed the ci/vrt/cleanup-cli-downloads branch from 0653879 to 98d23ed Compare July 22, 2024 08:24
@Hotell Hotell merged commit 5333195 into microsoft:master Jul 22, 2024
@Hotell Hotell deleted the ci/vrt/cleanup-cli-downloads branch July 22, 2024 10:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@fabricteam fabricteam fabricteam left review comments

@TristanWatanabe TristanWatanabe TristanWatanabe approved these changes

@mainframev mainframev mainframev approved these changes

Assignees

No one assigned

Labels

Area: Storywright CI

Projects

None yet

Milestone

July Project Cycle Q3 2024

Development

Successfully merging this pull request may close these issues.

4 participants

@Hotell @fabricteam @TristanWatanabe @mainframev